From 027de096bc6423f7e388a9d92e421fa32e6ce942 Mon Sep 17 00:00:00 2001
From: Robert Helewka <r@helu.ca>
Date: Fri, 8 May 2026 06:01:59 -0400
Subject: [PATCH] refactor: move nav items to base navbar template

Consolidate navigation items into the base navbar template instead of
requiring each app to override nav blocks. Nav links are now conditionally
rendered based on authentication status, removing the need for duplicate
nav block definitions in dashboard.html.
---
 .../templates/mnemosyne/dashboard.html         | 16 ----------------
 .../templates/themis/includes/navbar.html      | 18 ++++++++++++++++--
 2 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/mnemosyne/mnemosyne/templates/mnemosyne/dashboard.html b/mnemosyne/mnemosyne/templates/mnemosyne/dashboard.html
index 33a0dfb..92f9990 100644
--- a/mnemosyne/mnemosyne/templates/mnemosyne/dashboard.html
+++ b/mnemosyne/mnemosyne/templates/mnemosyne/dashboard.html
@@ -1,21 +1,5 @@
 {% extends "themis/base.html" %}
 
-{% block nav_items_desktop %}
-<li><a href="{% url 'dashboard' %}" class="font-semibold">Dashboard</a></li>
-<li><a href="{% url 'library:library-list' %}">Libraries</a></li>
-<li><a href="{% url 'library:search' %}">Search</a></li>
-<li><a href="{% url 'llm_manager:dashboard' %}">LLM Manager</a></li>
-<li><a href="{% url 'themis:key-list' %}">API Keys</a></li>
-{% endblock %}
-
-{% block nav_items %}
-<li><a href="{% url 'dashboard' %}">Dashboard</a></li>
-<li><a href="{% url 'library:library-list' %}">Libraries</a></li>
-<li><a href="{% url 'library:search' %}">Search</a></li>
-<li><a href="{% url 'llm_manager:dashboard' %}">LLM Manager</a></li>
-<li><a href="{% url 'themis:key-list' %}">API Keys</a></li>
-{% endblock %}
-
 {% block title %}Dashboard — Mnemosyne{% endblock %}
 
 {% block content %}
diff --git a/mnemosyne/themis/templates/themis/includes/navbar.html b/mnemosyne/themis/templates/themis/includes/navbar.html
index 19bd620..4ae34dd 100644
--- a/mnemosyne/themis/templates/themis/includes/navbar.html
+++ b/mnemosyne/themis/templates/themis/includes/navbar.html
@@ -13,7 +13,15 @@
             <ul tabindex="0"
                 class="menu menu-sm dropdown-content bg-base-200 rounded-box z-10 mt-3 w-52 p-2 shadow">
                 {% block nav_items_mobile %}
-                {% block nav_items %}{% endblock %}
+                {% block nav_items %}
+                {% if user.is_authenticated %}
+                <li><a href="{% url 'dashboard' %}">Dashboard</a></li>
+                <li><a href="{% url 'library:library-list' %}">Libraries</a></li>
+                <li><a href="{% url 'library:search' %}">Search</a></li>
+                <li><a href="{% url 'llm_manager:dashboard' %}">LLM Manager</a></li>
+                <li><a href="{% url 'themis:key-list' %}">API Keys</a></li>
+                {% endif %}
+                {% endblock %}
                 {% endblock %}
             </ul>
         </div>
@@ -28,7 +36,13 @@
     <div class="navbar-center hidden lg:flex">
         <ul class="menu menu-horizontal px-1">
             {% block nav_items_desktop %}
-            <!-- Apps fill this block with their nav items -->
+            {% if user.is_authenticated %}
+            <li><a href="{% url 'dashboard' %}">Dashboard</a></li>
+            <li><a href="{% url 'library:library-list' %}">Libraries</a></li>
+            <li><a href="{% url 'library:search' %}">Search</a></li>
+            <li><a href="{% url 'llm_manager:dashboard' %}">LLM Manager</a></li>
+            <li><a href="{% url 'themis:key-list' %}">API Keys</a></li>
+            {% endif %}
             {% endblock %}
         </ul>
     </div>